Closed
Conversation
Tyriar
reviewed
Jan 26, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
@PoetaKodu very cool 👍 will try get a review done this week/early next week. The main thing I want to check out is how the settings work, trackpad vs wheel and how close the experience is to monaco.
Member
|
Tested and trackpad scrolling isn't affected by the new option 👍 |
Tyriar
reviewed
Feb 3, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looking into this now, my first impressions are:
- The scroll speed is too slow, looks like monaco has a smooth scroll duration of 125ms and it feels a lot more responsive because of that
smoothScrollingStepIntervalseems like we don't need it and it should instead be replaced byrequestAnimationFrame- A duration would be preferable to
smoothScrollingSpeed, so the pointer device tells the terminal how much to scroll and smooth scroll animates that over x milliseconds. If the animation happens based on a number of lines each frame then scrolling a large amount of lines seems like it would be a bad experience?
Tyriar
requested changes
Feb 3, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Yeah the above is my main feedback, it would be better to move to duration-based scrolling and we should use requestAnimationFrame instead of setTimeout/setInterval. Interested in your thoughts, thanks!
Member
|
Implemented the needed changes in #3940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone.
I implemented smooth scrolling. I was annoyed that every time I scroll terminal in VS Code I lose track (see #1140 and microsoft/vscode#125950).
The option is disabled by default but can be enabled using terminal options.
Preview:
https://youtu.be/BCYdZwydmLw