Skip to content

trycatch characterJoiner handlers#3565

Merged
Tyriar merged 2 commits intoxtermjs:masterfrom
LabhanshAgrawal:characterJoiner
Nov 24, 2021
Merged

trycatch characterJoiner handlers#3565
Tyriar merged 2 commits intoxtermjs:masterfrom
LabhanshAgrawal:characterJoiner

Conversation

@LabhanshAgrawal
Copy link
Copy Markdown
Contributor

Fixes #3547

@Tyriar Tyriar added this to the 4.16.0 milestone Nov 24, 2021
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LabhanshAgrawal 👍

@Tyriar Tyriar merged commit 7b07289 into xtermjs:master Nov 24, 2021
@LabhanshAgrawal LabhanshAgrawal deleted the characterJoiner branch November 24, 2021 18:56
@LabhanshAgrawal
Copy link
Copy Markdown
Contributor Author

Can we get a patch release, please 🙏
4.16 is nearly 2 weeks later.

@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Nov 24, 2021

@LabhanshAgrawal any reason you don't just pick up the beta? I only really have time to release during our "debt week" which is in 2 weeks

@LabhanshAgrawal
Copy link
Copy Markdown
Contributor Author

Oh, didn't think about that. Will test with that and see. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A crashing character joiner brings down the whole terminal

2 participants