Halloween Lint using Putout (part 5)#3538
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Nov 8, 2021
Merged
Conversation
Tyriar
requested changes
Nov 4, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks like this caused tsc strict errors:
src/common/InputHandler.ts(64,18): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/common/InputHandler.ts(561,45): error TS2339: Property 'substring' does not exist on type 'string | Uint8Array'.
Property 'substring' does not exist on type 'Uint8Array'.
src/common/InputHandler.ts(562,43): error TS2339: Property 'subarray' does not exist on type 'string | Uint8Array'.
Property 'subarray' does not exist on type 'string'.
src/common/input/WriteBuffer.test.ts(12,18): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/common/input/WriteBuffer.test.ts(49,75): error TS2345: Argument of type 'string | Uint8Array' is not assignable to parameter of type 'Uint8Array'.
Type 'string' is not assignable to type 'Uint8Array'.
src/common/parser/EscapeSequenceParser.test.ts(17,18): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/common/parser/EscapeSequenceParser.test.ts(1737,7): error TS2322: Type 'unknown' is not assignable to type 'string | undefined'.
Type 'unknown' is not assignable to type 'string'.
addons/xterm-addon-attach/src/AttachAddon.ts(10,18): error TS7006: Parameter 'a' implicitly has an 'any' type.
addons/xterm-addon-attach/src/AttachAddon.ts(32,24): error TS2345: Argument of type 'string | ArrayBuffer' is not assignable to parameter of type 'string | Uint8Array'.
Type 'ArrayBuffer' is not assignable to type 'string | Uint8Array'.
Type 'ArrayBuffer' is missing the following properties from type 'Uint8Array': BYTES_PER_ELEMENT, buffer, byteOffset, copyWithin, and 22 more.
addons/xterm-addon-attach/src/AttachAddon.ts(32,63): error TS2769: No overload matches this call.
The last overload gave the following error.
Argument of type 'string | ArrayBuffer' is not assignable to parameter of type 'ArrayBuffer'.
Type 'string' is not assignable to type 'ArrayBuffer'.
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
coderaiser
force-pushed
the
chore/lint-using-putout
branch
from
d5bbb2a to
8d87eae
Compare
Contributor
Author
coderaiser
force-pushed
the
chore/lint-using-putout
branch
from
8d87eae to
c4e66ac
Compare
Member
|
On a sidenote: most promises removed from tests, are actually needed to force the return of a promise testing promise handling in the parser. So they should not be removed there. |
coderaiser
force-pushed
the
chore/lint-using-putout
branch
from
c4e66ac to
0753d24
Compare
Contributor
Author
|
@jerch just got back promises |
coderaiser
force-pushed
the
chore/lint-using-putout
branch
from
0753d24 to
c41f4e9
Compare
Contributor
Author
Tyriar
requested changes
Nov 5, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Lots of good changes here, I especially like the optional chaining.
Comment on lines
+61
to
+63
| new ThroughputRuntimeCase('', () => (({ | ||
| payloadSize: serializeAddon.serialize().length | ||
| })), { fork: false }).showAverageThroughput(); |
Member
There was a problem hiding this comment.
This was more readable before imo, also it doubled up the params for some reasons.
| }); | ||
| if (status && status.state !== 'granted') { | ||
| throw new Error('Permission to access local fonts not granted.'); | ||
| throw Error('Permission to access local fonts not granted.'); |
Member
There was a problem hiding this comment.
I kind of prefer new Error and new Array, let's remove that rule as well so this PR becomes a lot smaller. This is something a compiler should remove if they are equivalent imo.
src/common/CircularList.ts
Outdated
| // Reconstruct array, starting at index 0. Only transfer values from the | ||
| // indexes 0 to length. | ||
| const newArray = new Array<T | undefined>(newMaxLength); | ||
| const newArray = Array(newMaxLength); |
Member
There was a problem hiding this comment.
Not sure this was a safe thing to do removing the type here?
coderaiser
force-pushed
the
chore/lint-using-putout
branch
from
ff7a354 to
82f8e06
Compare
Contributor
Author
|
Disabled: |
coderaiser
commented
Nov 5, 2021
coderaiser
added a commit
to coderaiser/putout
that referenced
this pull request
Nov 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After successfully merged linting sessions part 1, part 2 and part 3, part 4 the time is come for part 5 :).
As usual, any rule can be disabled.
Command used:
putout . --fixApplied rules:
Current config for putout v21:
{ "rules": { "apply-is-array": ["on", { "inline": true }, "remove-useless-new": "off", "remove-useless-return": "off", "remove-useless-types-from-constants": "off", "remove-useless-type-convertion/with-double-negations": "off", "convert-typeof-to-is-type": "off", "apply-shorthand-properties": "off", "apply-destructuring": "off", "apply-numeric-separators": "off", "convert-assignment-to-comparison": "off", "convert-apply-to-spread": "off", "convert-math-pow": "off", "convert-for-to-for-of": "off", "convert-template-to-string": "off", "strict-mode": "off", "remove-useless-spread/object": "off", "remove-useless-array-constructor": "off", "remove-boolean-from-assertions": "off", "remove-iife": "off", "remove-console": "off", "remove-unused-variables": "off", "remove-useless-variables": "off", "merge-if-statements": "off", "promises/add-missing-await": "off", "promises/remove-useless-async": "off", "simplify-ternary": "off" }, "match": { "*.benchmark.ts": { "remove-unused-expressions": "off" } }, "plugins": [ "apply-shorthand-properties" ], "ignore": [ "*.md", "*.json", "*ignore", "*.yml", ".npmrc", "*.css", "out", "out-test", "demo" ] }Happy Halloween 🎃!