Adopt @playwright/test and improve integration tests#3460
Adopt @playwright/test and improve integration tests#3460Tyriar wants to merge 52 commits intoxtermjs:masterfrom
Conversation
| displayName: 'Integration tests (Chromium)' | ||
| - script: xvfb-run --auto-servernum -- bash -c "yarn test-api-firefox --headless --forbid-only" | ||
| displayName: 'Integration tests (Firefox)' | ||
| - script: yarn test-playwright --forbid-only |
There was a problem hiding this comment.
nit: In the config you can add: forbidOnly: !!process.env.CI that's how we do it, then you can drop the --forbid-only CLI argument everywhere.
azure-pipelines.yml
Outdated
| - script: xvfb-run --auto-servernum -- bash -c "yarn test-api-firefox --headless --forbid-only" | ||
| displayName: 'Integration tests (Firefox)' | ||
| - script: npx playwright install | ||
| displayName: 'Install PlayWright browsers' |
There was a problem hiding this comment.
| displayName: 'Install PlayWright browsers' | |
| displayName: 'Install Playwright browsers' |
It's Playwright 🙂
There was a problem hiding this comment.
@mxschmitt now that you're here, any idea how to solve this? Installing didn't see to fix:
6) [Firefox Stable] › ../../test/playwright/CharWidth.test.ts:20:5 › CharWidth Integration Tests › getStringCellWidth › ASCII chars
browserType.launch: Executable doesn't exist at /home/vsts/.cache/ms-playwright/firefox-1335/firefox/firefox
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚═════════════════════════════════════════════════════════════════════════╝
There was a problem hiding this comment.
Most likely because you have playwright and @playwright/test inside your package.json with different versions. I suggest to remove playwright and only have @playwright/test with the latest version.
(everything from playwright is also exported from @playwright/test node/package-wise)
There was a problem hiding this comment.
Another idea is since you are using yarn, to use yarn run playwright install instead.
This reverts commit 8fb80c3.
Tyriar
added
the
reference
|
This is too stale, it's available for reference when we want to try move to @playwright/test in the future. |
3 participants
Fixes #3446
Fixes #3326
Changes summary:
__awaiterwon't be on the page() => {}for all testspage.evaluateallows us to avoid the\\hackpollForfor most testsRemaining: