You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Tyriar I suggest to rethink the way we handle the bell for xterm.js v5. Idea:
Strip sound output handling from xterm.js.
Propagate onBell as interface to hook into the bell (make sound output an outer env problem). Here integrators can do whatever they want or suits their purpose.
Move current direct sound output to a default bell addon, that keeps working in browsers as now, but listens on onBell. If demanded, we could also extend the addon by other bell metaphors, like a visual bell and such.
Issue behind - the current default sound output handling uses an AudioContext internally, which is a rare resource in browser envs (can only be instantiated like 6 times or so). This might lead to weird problems on more complex integrations with multiple terminals. While the SoundService tries to work around that limitation by using a static context instance, it might not work everywhere (e.g. integration already holds all possible instances). The addon separation makes bell handling more flexible, e.g. a complex integration might have its own means to handle onBell, or the addon could be instantiated with an existing audio context instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#122938