Terminal.open: support WebComponent when checking DOM Node#3239
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Feb 1, 2021
sangxxh:fix/2642-terminal-open-check-shadow-dom
Merged
Terminal.open: support WebComponent when checking DOM Node#3239Tyriar merged 1 commit intoxtermjs:masterfrom sangxxh:fix/2642-terminal-open-check-shadow-dom
Tyriar merged 1 commit intoxtermjs:masterfrom
sangxxh:fix/2642-terminal-open-check-shadow-dom
Conversation
Tyriar
approved these changes
Feb 1, 2021
Member
Tyriar
left a comment
There was a problem hiding this comment.
Thanks for the thorough testing 👍
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2642
First contribution.
I've replicated the issue and debugged.
Debug
Before:
After:
Replicate Issue
In
demo/client.ts, find theif (document.location.pathname === "/test")block and put the code inside theDEBUG START/ENDcomment blocks below into it. Go tohttp://localhost:3000/testto check.