Set glyph fg color based on original bg, not selection #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves resolving the rgb channels of the original background color and encoding them using the RGB color mode. Fixes xtermjs#2599
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Dec 31, 2019
[email protected] Diff: xtermjs/xterm.js@8341c35...2a9e16b - Include in word separators xtermjs/xterm.js#2583 - Remove unused imports/functions xtermjs/xterm.js#2585 - force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560 - Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602 - v4.3.0 xtermjs/xterm.js#2605 - Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616 - Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590 - update version of node-pty xtermjs/xterm.js#2621 - Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625 - Expose texture atlas as API and use in demo xtermjs/xterm.js#2626 - Webgl v0.4.1 xtermjs/xterm.js#2628 - Add Linode to real world uses xtermjs/xterm.js#2636 - Added Gus to list of xterm real-world users xtermjs/xterm.js#2631 - Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637 - Move back to reseting parser only on RIS xtermjs/xterm.js#2640 - Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650 - format color value to style '#rrggbbaa' xtermjs/xterm.js#2629 - Use register over add for APIs returning disposables xtermjs/xterm.js#2651 - Standardize how colors helper lib is structured xtermjs/xterm.js#2653 - Fullwidth handling in buffer writes xtermjs/xterm.js#2644 - Target es5 in attach addon xtermjs/xterm.js#2654 Fixes #86194 Fixes #87918 Part of #87456
Tyriar
added a commit
that referenced
this pull request
Feb 4, 2020
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
[email protected] Diff: xtermjs/xterm.js@8341c35...2a9e16b - Include in word separators xtermjs/xterm.js#2583 - Remove unused imports/functions xtermjs/xterm.js#2585 - force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560 - Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602 - v4.3.0 xtermjs/xterm.js#2605 - Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616 - Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590 - update version of node-pty xtermjs/xterm.js#2621 - Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625 - Expose texture atlas as API and use in demo xtermjs/xterm.js#2626 - Webgl v0.4.1 xtermjs/xterm.js#2628 - Add Linode to real world uses xtermjs/xterm.js#2636 - Added Gus to list of xterm real-world users xtermjs/xterm.js#2631 - Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637 - Move back to reseting parser only on RIS xtermjs/xterm.js#2640 - Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650 - format color value to style '#rrggbbaa' xtermjs/xterm.js#2629 - Use register over add for APIs returning disposables xtermjs/xterm.js#2651 - Standardize how colors helper lib is structured xtermjs/xterm.js#2653 - Fullwidth handling in buffer writes xtermjs/xterm.js#2644 - Target es5 in attach addon xtermjs/xterm.js#2654 Fixes microsoft#86194 Fixes microsoft#87918 Part of microsoft#87456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2599
Part of #2600