New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent atlas missing exception when opened before attach #2575

Merged

Tyriar merged 1 commit into xtermjs:master from Tyriar:webgl_exception

Nov 23, 2019

Member

Tyriar commented Nov 23, 2019

See microsoft/vscode#85048

This should hopefully prevent that issue by preventing drawing and remembering to defer atlas creation if there are issues with dimensions on render.


          Prevent atlas missing exception when opened before attach

0bd0f3a

See microsoft/vscode#85048

Tyriar added this to the 4.3.0 milestone

Tyriar self-assigned this

Tyriar merged commit 1300b7a into xtermjs:master

Tyriar deleted the webgl_exception branch

November 23, 2019 00:06

Member Author

Tyriar commented Nov 23, 2019

This didn't end up fixing the problem after bringing it to VS Code 🙁, hard to repro this case in the demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet