Implement minimum contrast ratio #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke as part of this PR
|
1:
15:
|
Tyriar
force-pushed
the
322_minimum_contrast
branch
from
ea80f14 to
20b0a95
Compare
jerch
reviewed
Nov 12, 2019
We want to check when the background changed or when the foreground changed (and either the old or new value was inverse)
This probably wasn't causing a bug since the opposite values were being returned, it was wrong and made the code confusing though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature tries to ensure a minimum contrast ratio by increasing or reducing the luminance of cell foreground colors.
Fixes #1514
minimumContrastRatio: 1minimumContrastRatio: 7It helps fix an accessibility issue I have with some themes where
lscolors in particular clash and make something very unreadable like this:Fixed with
minimumContrastRatio: 4.5Care was taken with performance with the default skipping the code path all together, avoiding object creation and after the cache is done this should have very minimal impact on performance. This also includes a big reorganization of the DOM and WebGL glyph rendering code.
Note that this is not supported on the canvas renderer as non-cached glyphs would be required which are too slow.TODO: