-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip puppeteer download on unit test runs, fix windows tests, polish pipeline #2541
Conversation
Skipping puppeteer download seems to save about 15 seconds on Linux, let's see if caching yarn cache works. |
|
@Tyriar So the difference is basically a minute for a single pipeline? |
@jerch yeah, integration tests are mostly unchanged at but I'll see if I can reduce that a bit too. So right now we'll get faster compile/unit test feedback. |
Caching node_modules for integration tests didn't seem to work, also it ended up as 1gb so it was going to be slower anyway if it did. |
Final results gives faster compile and unit test builds to let us iterate faster on PRs:
* The actual run took 2m 23s but that's because cache restore took an abnormally long time just this run, number was adjusted for typical runtime Integration tests are basically the same. |
This passed fully on a rebuild |
Fixes #2539
Fixes #2542
Fixes #2543