Update unfocused cursor to match current cursor style#2455
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Oct 8, 2019
JeffreyCA:unfocused-cursor-style
Merged
Update unfocused cursor to match current cursor style#2455Tyriar merged 3 commits intoxtermjs:masterfrom JeffreyCA:unfocused-cursor-style
Tyriar merged 3 commits intoxtermjs:masterfrom
JeffreyCA:unfocused-cursor-style
Conversation
|
Thanks for your hardworking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2356.
Block cursor (unchanged)
When terminal is unfocused, it shows a outline of the block cursor.
Underline and bar cursors
When terminal is unfocused, it shows the underline or bar cursor. It always showed the outlined block cursor prior to this change.
Additional Change
This change revealed an unintended behaviour where if blinking is enabled and terminal is not focused, changing the cursor style did not update screen's cursor. A second change was made to force a refresh after options have changed regardless of whether blinking is enabled.
Tests
I tested unfocusing the terminal with all three styles and all three renderers (DOM, Canvas, WebGL) and verified proper cursor behaviour.