Skip to content

column sequences#2360

Merged
jerch merged 18 commits intoxtermjs:masterfrom
jerch:left_right_scroll
Oct 24, 2019
Merged

column sequences#2360
jerch merged 18 commits intoxtermjs:masterfrom
jerch:left_right_scroll

Conversation

@jerch
Copy link
Copy Markdown
Member

@jerch jerch commented Aug 4, 2019 •
edited
Loading

Basic SL / SR / DECIC / DECDC support.

TODO:

  • test files against xterm behavior
  • implement DECLRMM
  • test interaction with DECLRMM

Update: DECLRMM should go into a separate PR as its more involved (also influences other VT primitives).

@jerch jerch added the work-in-progress Do not merge label Aug 4, 2019
@jerch jerch self-assigned this Aug 4, 2019
@jerch jerch changed the title Left/right scroll support column sequences Aug 4, 2019
@jerch jerch mentioned this pull request Sep 3, 2019
Closed
11 tasks
@jerch jerch removed the work-in-progress Do not merge label Oct 24, 2019
@jerch
Copy link
Copy Markdown
Member Author

jerch commented Oct 24, 2019

@Tyriar To not get stale I removed DECLRMM from this PR as its more involved and better done separately.

Up for review.

@jerch
Copy link
Copy Markdown
Member Author

jerch commented Oct 24, 2019

Geez not yet done with this PR - DECIC and DECDC are margin aware, thus should only shift content between margins, its a NOOP outside. See http://www.bitsavers.org/pdf/dec/standards/EL-SM070-00_DEC_STD_070_Video_Systems_Reference_Manual_Dec91.pdf#page=406&zoom=auto,-38,762
Also for SL/SR xterm seems to apply margins...

Tyriar
Tyriar reviewed Oct 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any apps of note use this one that you're aware of?

@jerch
Copy link
Copy Markdown
Member Author

jerch commented Oct 24, 2019

@Tyriar With DECLRMM it can be used by apps to do partial viewport updates (like splitting in a multiplexer and such). Since this is supported for long in xterm and other emulators apps might shift to it, not sure if any does atm. Maybe ncurses already uses this, idk.

Already fixed in with the last commit, tests still to come.

@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Oct 24, 2019

@jerch k, ping me when ready to review 😃

@jerch
Copy link
Copy Markdown
Member Author

jerch commented Oct 24, 2019

@Tyriar Ping 😄

Tyriar
Tyriar approved these changes Oct 24, 2019
View reviewed changes
@Tyriar Tyriar added this to the 4.2.0 milestone Oct 24, 2019
@jerch jerch merged commit 527379d into xtermjs:master Oct 24, 2019
@jerch jerch deleted the left_right_scroll branch October 24, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@jerch jerch

Labels

None yet

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jerch @Tyriar