-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
type/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features
Milestone
Description
These logs make it difficult to parse logs of output:
xterm.js/src/common/services/CoreService.ts
Lines 77 to 88 in e969832
| // Fire onData API | |
| this._logService.debug(`sending data "${data}"`, () => data.split('').map(e => e.charCodeAt(0))); | |
| this._onData.fire(data); | |
| } | |
| public triggerBinaryEvent(data: string): void { | |
| if (this._optionsService.rawOptions.disableStdin) { | |
| return; | |
| } | |
| this._logService.debug(`sending binary "${data}"`, () => data.split('').map(e => e.charCodeAt(0))); | |
| this._onBinary.fire(data); | |
| } |
We should just show the string if debug log level, and show this in verbose. We could also log the character codes in a separate log calls so they can more easily be filtered out.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features