Skip to content

Only log character codes for verbose logging #5417

@Tyriar

Description

@Tyriar

These logs make it difficult to parse logs of output:

// Fire onData API
this._logService.debug(`sending data "${data}"`, () => data.split('').map(e => e.charCodeAt(0)));
this._onData.fire(data);
}
public triggerBinaryEvent(data: string): void {
if (this._optionsService.rawOptions.disableStdin) {
return;
}
this._logService.debug(`sending binary "${data}"`, () => data.split('').map(e => e.charCodeAt(0)));
this._onBinary.fire(data);
}

We should just show the string if debug log level, and show this in verbose. We could also log the character codes in a separate log calls so they can more easily be filtered out.

Metadata

Metadata

Assignees

Labels

type/enhancementFeatures or improvements to existing features

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions