-
Notifications
You must be signed in to change notification settings - Fork 1.8k
; inside the URL breaks the OSC hyperlink #4944
Copy link
Copy link
Closed
Labels
Milestone
Description
Tried this in both VSCode and Jupyterlab. It seems the OSC hyperlink integration doesn't work properly when the linked URL contains a ';'
The following submitted to terminator terminal emulator results in a link directing me to https://www.example.com/query;arg=1;arg=2;arg=3
printf '\e]8;;https://www.example.com/query;arg=1;arg=2;arg=3\e\\This is a link\e]8;;\e\\n'
Running the same in jupyter or VSCode, I end up being redirected to https://www.example.com/query, with the arguments truncated
Details
- Browser and browser version: Any
- OS version: Any
- xterm.js version: Any supporting OSC hyperlinks
Steps to reproduce
- Output a valid OSC hyperlink in tooling using xterm.js (See printf statement above)
- Observe the link is truncated
Reactions are currently unavailable