Serialize addon coordinates are backwards internally

This is the wrong way around:

https://github.com/xtermjs/xterm.js/blob/49eab6b1d9ffb110807e699a8b1396f60062ab7e/addons/addon-serialize/src/SerializeAddon.ts#L448-L451

https://github.com/xtermjs/xterm.js/blob/49eab6b1d9ffb110807e699a8b1396f60062ab7e/addons/addon-serialize/src/SerializeAddon.ts#L30-L33

I don't think this is an API facing bug, just confusing code.

	return handler.serialize({
	start: { x: selection.start.y, y: selection.start.x },
	end: { x: selection.end.y, y: selection.end.x }
	});

	const startRow = range.start.x;
	const endRow = range.end.x;
	const startColumn = range.start.y;
	const endColumn = range.end.y;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialize addon coordinates are backwards internally #4876

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Serialize addon coordinates are backwards internally #4876

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions