-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
type/debtTechnical debt that could slow us down in the long runTechnical debt that could slow us down in the long run
Milestone
Description
#4821 was caused because the compiler does not require that SearchAddon implemented the SearchAddon interface in xterm-addon-search. We do this in the core lib here:
xterm.js/src/browser/public/Terminal.ts
Lines 16 to 23 in c080624
| import { IBufferNamespace as IBufferNamespaceApi, IDecoration, IDecorationOptions, IDisposable, ILinkProvider, ILocalizableStrings, IMarker, IModes, IParser, ITerminalAddon, Terminal as ITerminalApi, ITerminalInitOnlyOptions, IUnicodeHandling } from 'xterm'; | |
| /** | |
| * The set of options that only have an effect when set in the Terminal constructor. | |
| */ | |
| const CONSTRUCTOR_ONLY_OPTIONS = ['cols', 'rows']; | |
| export class Terminal extends Disposable implements ITerminalApi { |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type/debtTechnical debt that could slow us down in the long runTechnical debt that could slow us down in the long run