Skip to content

Links can be computed on the wrong line data on Windows #4457

@Tyriar

Description

@Tyriar

VS Code issue: microsoft/vscode#178014

Repro:

Run this in demo:

echo "https://github.com/microsoft/vscode/issues/178014/github.com/microsoft/vscode/issues/178014
abc https://github.com/microsoft/vscode/issues/178014/github.com/microsoft/vscode/issues/178014 def
[10:45:12] https://github.com/microsoft/vscode/issues/178014/github.com/microsoft/vscode/issues/178014: alksmdlkasd"

Resize wider/narrower, this is at 32 cols:

image

The line data is correct here but the underline wrong:

image

Another repro I did saw the data very messed up:

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/bugSomething is misbehaving

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions