Skip to content

Improve search addon behavior when there are > 1000 results #4444

New issue
New issue
Closed
#4504
Closed
Improve search addon behavior when there are > 1000 results#4444
#4504
Labels
area/addon/searchhelp wantedtype/bugSomething is misbehaving
@Tyriar

Description

@Tyriar
Tyriar
opened on Mar 22, 2023

See microsoft/vscode#178017 for context, _searchResults gets set to undefined when there are > 1000 results:

xterm.js/addons/xterm-addon-search/src/SearchAddon.ts

Lines 168 to 172 in d6599bc

if (this._searchResults.size > 1000) {
this.clearDecorations();
this._resultIndex = undefined;
return;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/addon/searchhelp wantedtype/bugSomething is misbehaving

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions