Skip to content

Links get wrong position when they are after wide chars with canvas/webgl renderer #4294

@JasonXJ

Description

@JasonXJ

See the image below. Note that it only happens to the links detected by the weblinks addon but not OSC 8 links. It also only happens to webgl and canvas renderers but the dom one.
image

I looked at the code a bit. It seems that the web link addon uses the character position (i.e. "哈" is counted 1 even though it is a wide character) as the the value for IBufferCellPosition.x. Code here. Is this the correct way?

BTW, I am not sure whether this is just #2887.

Details

  • Browser and browser version: Chrome 110
  • xterm.js version: Tot

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions