-
Notifications
You must be signed in to change notification settings - Fork 1.8k
IDirtyRowService can be inlined into InputHandler #4147
Copy link
Copy link
Closed
Labels
type/debtTechnical debt that could slow us down in the long runTechnical debt that could slow us down in the long run
Milestone
Description
I think it's only used there and on related events:
xterm.js/src/common/CoreTerminal.ts
Lines 136 to 143 in 318abe6
| this.register(this._bufferService.onScroll(event => { | |
| this._onScroll.fire({ position: this._bufferService.buffer.ydisp, source: ScrollSource.TERMINAL }); | |
| this._dirtyRowService.markRangeDirty(this._bufferService.buffer.scrollTop, this._bufferService.buffer.scrollBottom); | |
| })); | |
| this.register(this._inputHandler.onScroll(event => { | |
| this._onScroll.fire({ position: this._bufferService.buffer.ydisp, source: ScrollSource.TERMINAL }); | |
| this._dirtyRowService.markRangeDirty(this._bufferService.buffer.scrollTop, this._bufferService.buffer.scrollBottom); | |
| })); |
Encapsulating this over having a service will simplify the codebase.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type/debtTechnical debt that could slow us down in the long runTechnical debt that could slow us down in the long run