Skip to content

Consolidate texture atlas code in canvas and webgl renderers #4065

@Tyriar

Description

@Tyriar

There's a lot of duplication between the webgl renderer and the canvas renderer in their respective texture atlas', they both essentially do the same thing with slightly different interfaces. This is particularly important for all the rendering edge cases, if they shared the same texture atlas code they would pretty much always look the same except for the cases where the glyphs are printed beyond the cell in the canvas renderer (as it clips each row).

I think we should move this to core similar to CustomGlyphs.ts, which is in core to share with addons, but not compiled into core itself: https://github.com/xtermjs/xterm.js/blob/master/src/browser/renderer/CustomGlyphs.ts

Related: #4062, microsoft/vscode#158984

Metadata

Metadata

Assignees

Labels

area/addon/webgltype/debtTechnical debt that could slow us down in the long run

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions