Skip to content

Improve names of IRenderDimensions interface members #3925

@Tyriar

Description

@Tyriar

Current:

export interface IRenderDimensions {
  scaledCharWidth: number;
  scaledCharHeight: number;
  scaledCellWidth: number;
  scaledCellHeight: number;
  scaledCharLeft: number;
  scaledCharTop: number;
  scaledCanvasWidth: number;
  scaledCanvasHeight: number;
  canvasWidth: number;
  canvasHeight: number;
  actualCellWidth: number;
  actualCellHeight: number;
}

We should standardize on scaled* -> device* and canvas*/actual* -> css*, including updating all the comments and related calculations.

Probably not a good one for an external PR because of the amount of changes this will require.

Metadata

Metadata

Assignees

Labels

type/debtTechnical debt that could slow us down in the long run

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions