Decoration element positions should be rounded

While working on https://github.com/xtermjs/xterm.js/issues/3770 I noticed the size of the decorations is different from the actual cell size:

![image](https://user-images.githubusercontent.com/2193314/167630634-a0d0c018-d96b-406d-87fd-7a0f9fbe89cb.png)

Likely fixed by rounding these:

https://github.com/xtermjs/xterm.js/blob/90f64ba6ccd45378cbb91c87af7cd216e3e03029/src/browser/Decorations/BufferDecorationRenderer.ts#L79-L80

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decoration element positions should be rounded #3774

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	element.style.width = `${(decoration.options.width \|\| 1) * this._renderService.dimensions.actualCellWidth}px`;
	element.style.height = `${(decoration.options.height \|\| 1) * this._renderService.dimensions.actualCellHeight}px`;

Decoration element positions should be rounded #3774

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions