-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
area/apibreaking-changeBreaks API and requires a major version bumpBreaks API and requires a major version bumptype/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features
Milestone
Description
(Coming from #3314.)
Consolidate bell handling as follows:
- Strip sound output handling from xterm.js.
- Propagate
onBellas interface to hook into the bell (make sound output an outer env problem). Here integrators can do whatever they want or suits their purpose. - Move current direct sound output to a default bell addon, that keeps working in browsers as now, but listens on
onBell. If demanded, we can later extend the addon by other bell metaphors, like a visual bell and such.
This cannot be done until next major release version (v5), as it involves changes to the terminal options.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/apibreaking-changeBreaks API and requires a major version bumpBreaks API and requires a major version bumptype/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features