Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug? #2615

Closed
thesoftwarephilosopher opened this issue Dec 6, 2019 · 2 comments · Fixed by #2616
Closed

Potential bug? #2615

thesoftwarephilosopher opened this issue Dec 6, 2019 · 2 comments · Fixed by #2616
Labels
type/bug Something is misbehaving
Milestone
4.4.0

Comments

@thesoftwarephilosopher
Copy link
Contributor

Handler is never unset:

xterm.js/src/browser/Lifecycle.ts

Lines 13 to 29 in bd0d267

export function addDisposableDomListener(
node: Element | Window | Document,
type: string,
handler: (e: any) => void,
useCapture?: boolean
): IDisposable {
node.addEventListener(type, handler, useCapture);
return {
dispose: () => {
if (!handler) {
// Already disposed
return;
}
node.removeEventListener(type, handler, useCapture);
}
};
}

@thesoftwarephilosopher
Copy link
Contributor Author

To be clear, the potential bug is that calling dispose() multiple times will probably keep calling removeEventListener. Probably need handler=null in there.

@jerch
Copy link
Member

jerch commented Dec 6, 2019

I'd call this not a bug, since removeEventListener is a NOOP for not attached handlers. Still this roundtrip into browser realms could be avoided, true.

Merged
@Tyriar Tyriar added this to the 4.4.0 milestone Dec 7, 2019
@Tyriar Tyriar added the type/bug Something is misbehaving label Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

Avoid roundtrip to browser when double-disposing.
3 participants
@Tyriar @thesoftwarephilosopher @jerch