Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use register instead of add for APIs that return disposables #2610

Closed
Tyriar opened this issue Dec 5, 2019 · 0 comments · Fixed by #2651
Closed

Use register instead of add for APIs that return disposables #2610

Tyriar opened this issue Dec 5, 2019 · 0 comments · Fixed by #2651
Assignees
@Tyriar
Labels
area/api type/enhancement Features or improvements to existing features
Milestone
4.4.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 5, 2019

I think add feels a little strange without a remove, VS Code uses register for providers/handlers/factories:

image

Some context: #2607 (comment)
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/api labels Dec 5, 2019
@Tyriar Tyriar added this to the 5.0.0 milestone Dec 5, 2019
@Tyriar Tyriar self-assigned this Dec 5, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 26, 2019
@Tyriar
Use register over add for APIs returning disposables
509327b 
Fixes xtermjs#2610
@Tyriar Tyriar mentioned this issue Dec 26, 2019
Merged
@Tyriar Tyriar modified the milestones: 5.0.0, 4.4.0 Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/api type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

Use register over add for APIs returning disposables Tyriar/xterm.js
1 participant
@Tyriar