Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make naming around color formats more consistent #2604

Closed
Tyriar opened this issue Dec 4, 2019 · 0 comments · Fixed by #2653
Closed

Make naming around color formats more consistent #2604

Tyriar opened this issue Dec 4, 2019 · 0 comments · Fixed by #2653
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
4.4.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2019 •
edited
Loading

https://github.com/xtermjs/xterm.js/blob/master/src/browser/Color.ts exploded in growth recently and I think it's time to look over it and make all the names more consistent as there are several color formats being dealt with:

  • IColor
  • rgba (number)
  • rgb (number) - this one is particularly dangerous as no compile error will happen if passing in rgba
  • [r, g, b, a] (number[])
  • [r, g, b] (number[])
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Dec 4, 2019
@Tyriar Tyriar added this to the 4.4.0 milestone Dec 4, 2019
@Tyriar Tyriar self-assigned this Dec 4, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 26, 2019
@Tyriar
Standardize how colors helper lib is structured
ee74130 
Fixes xtermjs#2604
@Tyriar Tyriar mentioned this issue Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

Standardize how colors helper lib is structured Tyriar/xterm.js
1 participant
@Tyriar