Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webgl: Selection over inverse cells doesn't render correctly #2599

Closed
Tyriar opened this issue Dec 4, 2019 · 0 comments · Fixed by #2650
Closed

Webgl: Selection over inverse cells doesn't render correctly #2599

Tyriar opened this issue Dec 4, 2019 · 0 comments · Fixed by #2650
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone
4.4.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2019 •
edited
Loading

image

VS Code: microsoft/vscode#86194
@Tyriar Tyriar changed the title Webgl: Selection over inverse cells doesn' Webgl: Selection over inverse cells doesn't render correctly Dec 4, 2019
This was referenced Dec 4, 2019
Closed
Closed
@Tyriar Tyriar added this to the 4.4.0 milestone Dec 5, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 26, 2019
@Tyriar
Set glyph fg color based on original bg, not selection
28d7edd 
This involves resolving the rgb channels of the original background
color and encoding them using the RGB color mode.

Fixes xtermjs#2599
@Tyriar Tyriar mentioned this issue Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

Set glyph fg color based on original bg, not selection Tyriar/xterm.js
1 participant
@Tyriar