Hi @Tyriar,
Although I have some pretty straight forward implementation for this, I do have some wonderings:

Why do we need this second iteration? (line 48)

xterm.js/src/addons/search/SearchHelper.ts

Lines 39 to 55 in 9e446a9

    
           // Search from ydisp + 1 to end 
        
           for (let y = startRow + 1; y < this._terminal._core.buffer.ybase + this._terminal.rows; y++) { 
        
             result = this._findInLine(term, y, searchOptions); 
        
             if (result) { 
        
               break; 
        
             } 
        
           } 
        
           // Search from the top to the current ydisp 
        
           if (!result) { 
        
             for (let y = 0; y < startRow; y++) { 
        
               result = this._findInLine(term, y, searchOptions); 
        
               if (result) { 
        
                 break; 
        
               } 
        
             } 
        
           }

Currently for multiple matches in the same line it only returns (and counts) the first occurrence. do you think this should first be redesigned before we return the number of results? In reference to Search addon: Allow finding multiple instances on the same line #1654

	// Search from ydisp + 1 to end
	for (let y = startRow + 1; y < this._terminal._core.buffer.ybase + this._terminal.rows; y++) {
	result = this._findInLine(term, y, searchOptions);
	if (result) {
	break;
	}
	}

	// Search from the top to the current ydisp
	if (!result) {
	for (let y = 0; y < startRow; y++) {
	result = this._findInLine(term, y, searchOptions);
	if (result) {
	break;
	}
	}
	}

Search addon: Return the number of results of a search #1659

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions