find and use overrides opts in lintText (#130)

forivall · sindresorhus · commit 040d8be1467d · 2016-09-26T11:13:06.000+07:00
* find and use overrides opts in lintText fixes sindresorhus/atom-linter-xo#20 * test overrides support for lintText * remove unnecessary `|| process.cwd()` * refactor to directly calculate overrides instead of grouping
diff --git a/index.js b/index.js
@@ -6,6 +6,16 @@ var optionsManager = require('./options-manager');
 
 exports.lintText = function (str, opts) {
 	opts = optionsManager.preprocess(opts);
+
+	if (opts.overrides && opts.overrides.length) {
+		var overrides = opts.overrides;
+		delete opts.overrides;
+
+		var filename = path.relative(opts.cwd, opts.filename);
+		var foundOverrides = optionsManager.findApplicableOverrides(filename, overrides);
+		opts = optionsManager.mergeApplicableOverrides(opts, foundOverrides.applicable);
+	}
+
 	opts = optionsManager.buildConfig(opts);
 
 	var engine = new eslint.CLIEngine(opts);
diff --git a/options-manager.js b/options-manager.js
@@ -164,6 +164,10 @@ function findApplicableOverrides(path, overrides) {
 	};
 }
 
+function mergeApplicableOverrides(baseOptions, applicableOverrides) {
+	return deepAssign.apply(null, [emptyOptions(), baseOptions].concat(applicableOverrides.map(normalizeOpts)));
+}
+
 // Creates grouped sets of merged options together with the paths they apply to.
 function groupConfigs(paths, baseOptions, overrides) {
 	var map = {};
@@ -173,7 +177,7 @@ function groupConfigs(paths, baseOptions, overrides) {
 		var data = findApplicableOverrides(x, overrides);
 
 		if (!map[data.hash]) {
-			var mergedOpts = deepAssign.apply(null, [emptyOptions(), baseOptions].concat(data.applicable.map(normalizeOpts)));
+			var mergedOpts = mergeApplicableOverrides(baseOptions, data.applicable);
 			delete mergedOpts.files;
 
 			arr.push(map[data.hash] = {
@@ -201,6 +205,7 @@ exports.mergeWithPkgConf = mergeWithPkgConf;
 exports.normalizeOpts = normalizeOpts;
 exports.buildConfig = buildConfig;
 exports.findApplicableOverrides = findApplicableOverrides;
+exports.mergeApplicableOverrides = mergeApplicableOverrides;
 exports.groupConfigs = groupConfigs;
 exports.preprocess = preprocess;
 exports.emptyOptions = emptyOptions;
diff --git a/package.json b/package.json
@@ -93,6 +93,7 @@
     "eslint-plugin-react": "^6.3.0",
     "execa": "^0.4.0",
     "nyc": "^8.3.0",
+    "pify": "^2.3.0",
     "proxyquire": "^1.7.3",
     "temp-write": "^2.0.1",
     "xo": "sindresorhus/xo#v0.16.0"
diff --git a/test/api.js b/test/api.js
@@ -1,7 +1,11 @@
+import fs from 'fs';
 import path from 'path';
 import test from 'ava';
+import pify from 'pify';
 import fn from '../';
 
+const readFile = pify(fs.readFile, Promise);
+
 const hasRule = (results, ruleId) => results[0].messages.some(x => x.ruleId === ruleId);
 
 test('.lintText()', t => {
@@ -58,3 +62,18 @@ test('.lintText() - regression test for #71', t => {
 	}).results;
 	t.is(results[0].errorCount, 0, results[0]);
 });
+
+test('lintText() - overrides support', async t => {
+	const cwd = path.join(__dirname, 'fixtures/overrides');
+	const bar = path.join(cwd, 'test/bar.js');
+	const barResults = fn.lintText(await readFile(bar, 'utf8'), {filename: bar, cwd}).results;
+	t.is(barResults[0].errorCount, 0, barResults[0]);
+
+	const foo = path.join(cwd, 'test/foo.js');
+	const fooResults = fn.lintText(await readFile(foo, 'utf8'), {filename: foo, cwd}).results;
+	t.is(fooResults[0].errorCount, 0, fooResults[0]);
+
+	const index = path.join(cwd, 'test/index.js');
+	const indexResults = fn.lintText(await readFile(bar, 'utf8'), {filename: index, cwd}).results;
+	t.is(indexResults[0].errorCount, 0, indexResults[0]);
+});
diff --git a/test/fixtures/overrides/package.json b/test/fixtures/overrides/package.json
@@ -14,7 +14,8 @@
       }
     ],
     "rules": {
-      "import/no-extraneous-dependencies": 0
+      "import/no-extraneous-dependencies": 0,
+      "ava/no-ignored-test-files": 0
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,8 @@`
`14`	`14`	`}`
`15`	`15`	`],`
`16`	`16`	`"rules": {`
`17`		`- "import/no-extraneous-dependencies": 0`
	`17`	`+ "import/no-extraneous-dependencies": 0,`
	`18`	`+ "ava/no-ignored-test-files": 0`
`18`	`19`	`}`
`19`	`20`	`}`
`20`	`21`	`}`