Skip to content

fix: [0.8.x] update ownerDocument when moving nodes between documents#933

Merged
karfau merged 2 commits into
xmldom:release-0.8.xfrom
shunkica:release-0.8.x
Aug 17, 2025
Merged

fix: [0.8.x] update ownerDocument when moving nodes between documents#933
karfau merged 2 commits into
xmldom:release-0.8.xfrom
shunkica:release-0.8.x

Conversation

@shunkica

Copy link
Copy Markdown
Collaborator

Resolves issue #932

@shunkica shunkica requested a review from karfau August 17, 2025 10:33
@shunkica shunkica changed the title Update ownerDocument when moving nodes between documents fix: [0.8.x] update ownerDocument when moving nodes between documents Aug 17, 2025
@karfau

karfau commented Aug 17, 2025

Copy link
Copy Markdown
Member

Thank you for your continued contributions, especially the great test coverage.

Do I understand correctly that this is an issue in 0.8.x and 0.9.x?
If so, I usually first land the fix on master and afterwards apply it to the release-0.8.x branch.
Are you also planning to provide a PR against the master branch?

But since you did it the other way around I took the opportunity to turn on GitHub checks for 0.8.x versions.

@karfau

karfau commented Aug 17, 2025

Copy link
Copy Markdown
Member

PS: I have some other fixes to add to 0.8.x before doing another release.

@karfau karfau merged commit cd97add into xmldom:release-0.8.x Aug 17, 2025
21 checks passed
@shunkica

Copy link
Copy Markdown
Collaborator Author

@karfau I did it for 0.8.x since that is what I am using. If you want I can also make a PR for the master with the same changes.

@karfau karfau added this to the 0.8.11 milestone Aug 17, 2025
@karfau

karfau commented Aug 17, 2025

Copy link
Copy Markdown
Member

@shunkica providing the same fix against master would be very much appriciated, thx.

@karfau

karfau commented Aug 17, 2025

Copy link
Copy Markdown
Member

I have released 0.8.11 containing your fix, which was straight forward due to the outdated devDpendencies on that branch (previous release took place in Deember 2023).

@shunkica

Copy link
Copy Markdown
Collaborator Author

That is unfortunate. There is still an issue with importNode which I am still working on.

@karfau

karfau commented Aug 17, 2025

Copy link
Copy Markdown
Member

Well now I got it working, the next one will be faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants