Skip to content

Implementation of hasAttributes#804

Merged
karfau merged 5 commits into
xmldom:masterfrom
Speech-Rule-Engine:feature/hasAttributes
Dec 12, 2024
Merged

Implementation of hasAttributes#804
karfau merged 5 commits into
xmldom:masterfrom
Speech-Rule-Engine:feature/hasAttributes

Conversation

@zorkow

@zorkow zorkow commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

PR contributes the implementaton of the Level2 Core function hasAttributes.

  • Adds basic implementation in dom.js
  • Adds a set of tests in element.test.js

@codecov

codecov Bot commented Dec 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (a561f53) to head (2341623).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   95.05%   95.06%           
=======================================
  Files           8        8           
  Lines        2165     2167    +2     
  Branches      569      570    +1     
=======================================
+ Hits         2058     2060    +2     
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karfau karfau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution!

@karfau karfau merged commit 07502cd into xmldom:master Dec 12, 2024
@zorkow zorkow deleted the feature/hasAttributes branch December 16, 2024 11:51
@karfau karfau added this to the 0.9.7 milestone Jan 19, 2025
@karfau

karfau commented Jan 19, 2025

Copy link
Copy Markdown
Member

@zorkow I just realized that we forgot to add this method to the types. Sadly I only realized it after 0.9.7 has been released.
Happy to approve a related PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants