Skip to content

fix: Convert all line separators to LF#66

Merged
brody2consult merged 1 commit into
xmldom:masterfrom
karfau:56/consistent-line-separators
Jun 28, 2020
Merged

fix: Convert all line separators to LF#66
brody2consult merged 1 commit into
xmldom:masterfrom
karfau:56/consistent-line-separators

Conversation

@karfau

@karfau karfau commented Jun 28, 2020

Copy link
Copy Markdown
Member

This just converts the files, no enforcement yet

fixes #56

This just converts the files, no enforcement yet

fixes xmldom#56
@karfau

karfau commented Jun 28, 2020

Copy link
Copy Markdown
Member Author

@brodybits Do you think it should be part of this PR to enforce LF using one of the methods described in the ticket?
And if so, which one would you prefer?

PS: I just scanned the changes and I didn't find any multiline XML snippets in those files.

@brody2consult brody2consult left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git show -b 8a31e shows no extra changes
npm test on 8a31e is OK

@brody2consult brody2consult merged commit 0ade062 into xmldom:master Jun 28, 2020
@karfau karfau deleted the 56/consistent-line-separators branch June 28, 2020 19:59
This was referenced Mar 9, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixed line endings in the repo

2 participants