Skip to content

chore: use node v16 for development#517

Merged
karfau merged 2 commits into
masterfrom
bump-dev-node-version
Jul 20, 2023
Merged

chore: use node v16 for development#517
karfau merged 2 commits into
masterfrom
bump-dev-node-version

Conversation

@karfau

@karfau karfau commented Jul 19, 2023

Copy link
Copy Markdown
Member
  • add .nvmrc and .node-version to indicate node version to use for development
  • update package-lock.json version
  • bump eslint and prettier related versions to use prettier v3
  • update GitHub workflow job lint to use node v16

@socket-security

socket-security Bot commented Jul 19, 2023

Copy link
Copy Markdown

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
prettier 2.8.8...3.0.0 filesystem, environment +0/-0 8.55 MB prettier-bot
@homer0/prettier-plugin-jsdoc 6.0.5...7.0.2 None +1/-1 8.73 MB homer0
eslint 8.44.0...8.45.0 None +0/-1 2.89 MB eslintbot

🚮 Removed packages: [email protected]

@karfau karfau force-pushed the bump-dev-node-version branch from c0f8d60 to 52bdcd7 Compare July 19, 2023 20:42
@karfau karfau marked this pull request as ready for review July 19, 2023 21:06
@karfau

karfau commented Jul 19, 2023

Copy link
Copy Markdown
Member Author

@shunkica With this PR we are using the latest version of all the prettier and eslint related packages and a more recent package-lock.json format.

Please make sure to update your dev environment and let me know if you have any issues.
(I'm using nvm to node version management, but have no experience with doing that on windows, let me know what works for you.)

@karfau karfau requested a review from shunkica July 19, 2023 21:13
Comment thread package.json
"eslint-plugin-anti-trojan-source": "1.1.1",
"eslint-plugin-es5": "1.5.0",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-prettier": "5.0.0",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not dropped, but bumped

@shunkica shunkica left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants