fix!: Set nodeName property to ProcessingInstruction#509
Conversation
|
Hey @cjbarth this is great news and an excelent additional set of tests. I have just one remark: Please keep the
and ideally the tests should also make sure both values are aligned. (I know it's not ideas to keep a reference to the value twice since they can get out of sync but are currently not able to have setters and getters for all supported runtimes, so that's a general issue in the code base.) |
|
Oh and please run |
I completely agree that |
|
As a side point, I'm curious why this library isn't at 1.x yet. The API seems stable so I would expect a semver 1.0.0 would have been released. |
Done. |
|
Thank you for insisting/clarification. |
|
You can have a look at the milestones that we currently have put all issues in that we are aware if. |
Closes #505 Co-authored-by: Chris Barth <[email protected]>
Closes #505 Co-authored-by: Chris Barth <[email protected]>
|
released as 0.7.12( (0.7.12 and 0.8.9 still set the |
nodeName property with tests to ProcessingInstructionnodeName property to ProcessingInstruction
Closes #505
BREAKING CHANGE: (only of 0.9.x) the
tagNameproperty is no longer set since aProcessingInstructionis not anElement