fix: Throw DOMException when calling removeChild with invalid parameter#494
Merged
Conversation
…meter BREAKING-CHANGE: Previously it was possible (but not documented) to call `Node.removeChild` with any node in the tree, and with certain exceptions, it would work. This is no longer the case: calling `Node.removeChild` this way will now throw a NotFoundError DOMException, as it is described by the specs. https://dom.spec.whatwg.org/#concept-node-pre-remove Fixes #135
karfau
force-pushed
the
135/throw-not-found
branch
from
479a9b9 to
258d194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Previously it was possible (but not documented) to call
Node.removeChildwith any node in the tree,and with certain exceptions, it would work. This is no longer the case: calling
Node.removeChildwith an argument that is not a direct child of the node that it is called from, will throw a NotFoundError DOMException, as it is described by the specs.https://dom.spec.whatwg.org/#concept-node-pre-remove
Fixes #135