fix: extend list of HTML entities#489
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @see DOMParser.parseFromString | ||
| * @see DOMImplementation.prototype.createHTMLDocument | ||
| * @see https://html.spec.whatwg.org/#named-character-references WHATWG HTML(5) Spec | ||
| * @see https://html.spec.whatwg.org/entities.json JSON |
There was a problem hiding this comment.
Do you know how often this file changes?
Maybe it is in some version control where this information could be looked up?
(Not required for landing this PR, but I'm wondering whether it would make sense to run a scheduled action that checks whether our version is still in sync and maybe even creates a branch/PR with an update if there is one.)
There was a problem hiding this comment.
https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references states that it stable and will not change
Can you provide a short overview how it is simplified? I also spotted that some keys in the original are mapped with and without trailing |
karfau
left a comment
karfau
left a comment
There was a problem hiding this comment.
Thank you for investing the time to prepare this
karfau
changed the title
|
Thanks for merging the PR. Do you already have an ETA for the 0.9.0 release? |
Simplification was really only removing duplicates, in particular, since the sax parser assume that all entities are formatted as |
Sorry, no ETA for that yet. |
|
@zorkow what is your opinion on merging this change into 0.8 and naxbe even 0.8 branch as a fix? |
|
@karfau I am all for that. That would allow us to release the next versions of the node library of SRE (v4.1) and MathJax (v4) based on |
Adds the full list of 2125 named character references that can be used in HTML. This is a simplified version of https://html.spec.whatwg.org/entities.json. (cherry picked from commit ddfa511)
Adds the full list of 2125 named character references that can be used in HTML. This is a simplified version of https://html.spec.whatwg.org/entities.json. (cherry picked from commit ddfa511)
|
This change is now part of the |
|
Quick question: does that also include the `compareDocumentPosition`
changes?
…On Tue, 30 May 2023 at 21:15, Christian Bewernitz ***@***.***> wrote:
This change is now part of the latest version 0.8.8
<https://github.com/xmldom/xmldom/releases/tag/0.8.8>
and 0.7.11 <https://github.com/xmldom/xmldom/releases/tag/0.7.11>
—
Reply to this email directly, view it on GitHub
<#489 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLTZX53BMZNHOQUDCULM73XIZBORANCNFSM6AAAAAAYE55G6Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm currently not considering doing that for the feature you contributed in #488, this would only be part of 0.9.0, hope that still works for the things you mentioned above. |
3 participants
Adds the full list of 2125 named character references that can be used in HTML.
This is a simplified version of https://html.spec.whatwg.org/entities.json.