Skip to content

fix: properly parse closing where the last attribute has no value#485

Merged
karfau merged 4 commits into
xmldom:masterfrom
Bulandent:fix-without_attr_value-0324
Mar 31, 2023
Merged

fix: properly parse closing where the last attribute has no value#485
karfau merged 4 commits into
xmldom:masterfrom
Bulandent:fix-without_attr_value-0324

Conversation

@Bulandent

@Bulandent Bulandent commented Mar 24, 2023 •
edited by karfau
Loading

Copy link
Copy Markdown
Contributor

Closes #486

@Bulandent Bulandent changed the title resolving tags without attribute values causes confusion fix: resolving tags without attribute values causes confusion Mar 24, 2023
@karfau

karfau commented Mar 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Since all tests are green, it means nothing covered that condition yet. Would be great to add your test case to the PR,
so it never breaks again.

Do you want to try it?

@Bulandent

Bulandent commented Mar 28, 2023

Copy link
Copy Markdown
Contributor Author

Since all tests are green, it means nothing covered that condition yet. Would be great to add your test case to the PR, so it never breaks again.

Do you want to try it?

Ok, I haved push the test case about without attr values。

@karfau

karfau commented Mar 28, 2023

Copy link
Copy Markdown
Member

Awesome.
I needed to revert the lock file you pushed.
And I will take the time within this week to try to understand the change a bit better, before I will land it and publish the next 0.7 and 0.8 release with this fix.
Thx for you contribution and investment.

@Bulandent

Bulandent commented Mar 28, 2023

Copy link
Copy Markdown
Contributor Author

Awesome. I needed to revert the lock file you pushed. And I will take the time within this week to try to understand the change a bit better, before I will land it and publish the next 0.7 and 0.8 release with this fix. Thx for you contribution and investment.

You are welcome. This was my first pr submission for an open source project, and I felt really good about it. 😁

@karfau karfau force-pushed the fix-without_attr_value-0324 branch from 61f1a3f to 59089b8 Compare March 31, 2023 08:27
@karfau

karfau commented Mar 31, 2023

Copy link
Copy Markdown
Member

I love your solution to the problem.
Will go ahead and land and release.

@karfau karfau merged commit 5c671dc into xmldom:master Mar 31, 2023
@karfau karfau changed the title fix: resolving tags without attribute values causes confusion fix: properly parse closing where the last attribute has no value Mar 31, 2023
karfau pushed a commit that referenced this pull request Mar 31, 2023
@Bulandent @karfau
fix: properly parse closing where the last attribute has no value (#485)
b67b3d3 
Closes #486
karfau pushed a commit that referenced this pull request Mar 31, 2023
@Bulandent @karfau
fix: properly parse closing where the last attribute has no value (#485)
8624000 
Closes #486
karfau pushed a commit that referenced this pull request Mar 31, 2023
@Bulandent @karfau
fix: properly parse closing where the last attribute has no value (#485)
eae888a 
Closes #486
@karfau

karfau commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes are available in 0.7.10 and 0.8.7 releases
(Since I'm still working on something for the upcoming next release 0.9.0-beta.7, this fix will only be included once that version is released.)

@karfau karfau mentioned this pull request Apr 2, 2023
Merged
karfau added a commit that referenced this pull request Apr 2, 2023
@karfau
test: reduce output by using getTestWrapper (#487)
535050f 
and adding snapshots for warnings

The additional output was introduced by the new tests in #485
@louiechristie louiechristie mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karfau karfau karfau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parsing an attribute without a value can cause code confusion

2 participants

@Bulandent @karfau