fix: several issues in NamedNodeMap and Element#482
Merged
Conversation
karfau
added
the
breaking change
karfau
added
bug
Member
Author
|
According to the spec the |
karfau
force-pushed
the
46/NamedNodeMap.getNamedItem
branch
2 times, most recently
from
b4fc55b to
2994bc2
Compare
- properly remove item from previous last index - set `ownerElement` to `null` even when `ownerElement.ownerDocument` is not set - throw DOMException when there is no matching attribute - add test coverage - drop unreachable code
karfau
force-pushed
the
46/NamedNodeMap.getNamedItem
branch
from
2994bc2 to
9658a0b
Compare
and apply it everywhere. - Initialize `Attr` with required `null` values. - make `NamedNodeMap.setNamedItemNS` an alias for `NamedNodeMap.setNamedItem` some tests still need cleanup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
karfau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ownerElementtonulleven whenownerElement.ownerDocumentis not set (which is an edge case which doesn't happen when parsing XML)DOMExceptionwhen there is no matching attributeElementAPI which can throwDOMExceptionas declared in the specsnullinAttrconstructorBREAKING CHANGES: Mainly not throwing when removing an attribute that doesn't exist and other behavior that was different from the specification.
closes #46
see #477