fix: getAttribute and getAttributeNS should return null#477
Merged
Conversation
base on https://dom.spec.whatwg.org/#dom-element-getattribute, getAttribute() and related methods should return null for not existing attributes. speediness plea.
Member
|
Thank you for the contribution. |
Contributor
Author
yes, you're right, I'll try |
karfau
reviewed
Feb 22, 2023
karfau
left a comment
karfau
left a comment
Member
There was a problem hiding this comment.
I will have a closer look at the implementation of the related API like set and remove, to see if they are aligned with the spec, to make sure my suggested simplification doesn't break anything.
karfau
added
spec:DOM-Level-2
Member
|
I had a look at it and fond some more issues, but those will be covered in a follow up PR by me, after which I will create the next beta release. Thank you for your contribution. |
karfau
changed the title
getAttribute and getAttributeNS should return null
xiaopanshi
added a commit
to xiaopanshi/xmldom
that referenced
this pull request
Feb 27, 2023
…xmldom#477)" This reverts commit 24108d4.
Contributor
Author
|
My great pleasure. |
xiaopanshi
added a commit
to xiaopanshi/xmldom
that referenced
this pull request
Feb 27, 2023
…xmldom#477)" This reverts commit 24108d4.
karfau
added a commit
that referenced
this pull request
Mar 19, 2023
karfau
added a commit
that referenced
this pull request
Apr 2, 2023
karfau
added a commit
that referenced
this pull request
Apr 2, 2023
karfau
added a commit
that referenced
this pull request
Jun 9, 2023
- proper order in finding attributes (only affects duplicate attributes, which can only be created manually and anyways produce invalid XML) - properly remove item from previous last index (was not iterated over but the reference was kept) - set `ownerElement` to `null` even when `ownerElement.ownerDocument` is not set (which is an edge case which doesn't happen when parsing XML) - throw `DOMException` when there is no matching attribute - add test coverage - add doc comments regarding differences to the specification that still exist: - no named property indices support - add validation of qualified names in `Element` API which can throw `DOMException` as declared in the specs - always initialize required properties with `null` in `Attr` constructor BREAKING CHANGES: Mainly not throwing when removing an attribute that doesn't exist and other behavior that was different from the specification. closes #46 see #477
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Element.getAttributeandElement.getAttributeNSreturnnullif the attribute doesn't existcloses #46
https://dom.spec.whatwg.org/#dom-element-getattribute