test: Add executable examples for node and typescript#317
Merged
Conversation
karfau
force-pushed
the
examples/nodejs
branch
6 times, most recently
from
1645c9c to
973f2dc
Compare
karfau
changed the title
karfau
force-pushed
the
examples/nodejs
branch
3 times, most recently
from
443e041 to
8b01397
Compare
Member
|
I will try to review later this week, apologies for the extra delays. |
Member
Author
|
@brodybits Thx, but even though I'm "happy about the current state of this PR", which is why it's no longer a draft, it is just an experiment. |
karfau
force-pushed
the
examples/nodejs
branch
from
8b01397 to
b8be778
Compare
and make script verbose and more explicit
Member
Author
|
@brodybits please let me know if you have time to look at this. I would love to land this before continuing to work on #338, to see the impact on potential changes to the type definitions. If you don't have time for this, just let meknow as well, in that case I'm confident enough to land it. |
karfau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of the threads in #214 I'm have added executable examples and test them as github actions to make sure they don't break.