ci(github): Split test and lint steps into jobs#304
Merged
Conversation
karfau
added
code style
infrastructure
Member
Author
|
@brodybits Do you think we can land this? |
Member
|
I may need another 1-2 days to look at these, my apologies. |
karfau
force-pushed
the
split-test-lint
branch
from
4634be0 to
d4e7695
Compare
Pin node minor version to prevent the regression nodejs/node#40030
This was referenced Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to allow linting to be listed as a separately failing check in the PR.
Really fixes #111
Note: I don't think there is any benefit of splitting them into different files as of now.