Completely remove remaining use of Vows#126
Merged
brody2consult merged 10 commits intoSep 18, 2020
Merged
Conversation
added 6 commits
September 16, 2020 19:50
…tely-remove-remaining-use-of-vows
karfau
approved these changes
Sep 18, 2020
added 3 commits
September 18, 2020 01:44
…tely-remove-remaining-use-of-vows Note that I did `git checkout --ours test` to avoid the conflicts in `test`. Next step is to run Pretter on `test` to properly reformat the updated modules.
Member
Author
|
Hey @karfau can you check these changes once again? I merged changes from master, using |
…tely-remove-remaining-use-of-vows
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In followup to PR #121 (port to Jest) and related to PR #89 (use mostly strict assertions), this completely removes remaining use of Vows and related package scripts no longer needed.
TODO items:
/cc @awwright @karfau