Port Vows tests to Jest & remove test:vows script#121
Conversation
karfau
left a comment
There was a problem hiding this comment.
This looks awesome!
I agree as a next step we should convert the custom assertions to jest's expect and get rid if the whole complicated assertion stuff. But rather in a separate PR, otherwise git might no longer be able to treat those files as moved.
|
One silly question: did you run stryker with this branch? What is the result? |
|
Thanks for the quick review. No I did not try with Stryker. My machine is way too slow to handle it and I was having some issues with cloud access. I am watching the Stryker run on GitHub now. Good news is that the score seems to be above 80% now. The bad news is that it seems to be quite a bit slower. We should probably switch over to Jest runner. I am now very hopeful that the efforts here and in #112 can help unblock further cleanup and upcoming contributions. |
|
I think the migration to jest is still incomplete, but I'm not sure what the next step should be:
I'm happy to take over some part of it to get rid of vows, but we should be clear about order and who is responsible for which part, to avoid "stepping on each others toes". |
|
Yup. My primary purpose was to help unblock some needed progress. I would definitely favor that we continue the discussion in #72. In terms of priorities, I think people should just work on whatever is most important to them in general. To avoid stepping on each other's toes, I would favor that whoever starts working on something raise a draft PR. Thanks again for all of your contributions, much appreciated !! |
I have done a very simple port of the Vows tests to Jest.
The one exception is
test/assert.vows.checks.js, which I think can be removed by converting the custom assertions to more standard, strict assertions like @awwright started in PR #89.I think this could be another positive step towards the more future-proof testing strategy discussed in #72 and avoid issues like stryker-mutator/stryker-js#2459 with Stryker.