apply Prettier formatting with no semicolons#120
Closed
brody2consult wants to merge 10 commits into
Closed
Conversation
added 6 commits
September 15, 2020 12:58
added 4 commits
September 16, 2020 15:54
This reverts commit b3fef09.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that Prettier formatting would touch most lines of the code anyway, as we can see in PR #110, my idea is now to remove semicolons at the same time.
I would continue to favor improving test coverage, as proposed in PR #112, before merging this one.