eslint with Prettier formatting [with semicolons]#110
Closed
brody2consult wants to merge 26 commits into
Closed
Conversation
added 22 commits
August 17, 2020 18:23
rationale: - ecmaVersion >= 6 is needed for test - newer ES support is not needed, not wanted for older browser support
NOTES: `git diff -b` / `git show -b` should show very limited output resulting from eslint --fix with these changes adding `?w=1` to URL of commit or PR files on GitHub should hide most of the output from the whitespace changes
3 tasks
brody2consult
changed the title
added 4 commits
September 15, 2020 12:38
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PRs #102, this is a proposal to format the code with Prettier.
Given that this PR overwrites such a large proportion of the code, I would favor that we skip PR #102 and incur these updates all at once.
I would favor that we improve the test coverage (issue #103) before merging these updates.