Skip to content

Update Vulkan packages to 1.4.335+0#9134

Merged
waruqi merged 5 commits into
xmake-io:devfrom
SirLynix:vulkan-sdk-1.4.335+0
Jan 20, 2026
Merged

Update Vulkan packages to 1.4.335+0#9134
waruqi merged 5 commits into
xmake-io:devfrom
SirLynix:vulkan-sdk-1.4.335+0

Conversation

@SirLynix

@SirLynix SirLynix commented Jan 17, 2026

Copy link
Copy Markdown
Member

@SirLynix SirLynix mentioned this pull request Jan 17, 2026
Open
@gemini-code-assist

gemini-code-assist Bot commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @SirLynix, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically updates the version of various Vulkan ecosystem packages to 1.4.335+0. This ensures that all dependent components, including headers, tools, and utility libraries, are aligned with the latest Vulkan SDK release, providing access to new features, bug fixes, and performance improvements.

Highlights

  • Vulkan Ecosystem Update: All relevant Vulkan-related packages have been updated to version 1.4.335+0, ensuring compatibility with the latest SDK.
  • Package Version Bumps: Specifically, glslang, spirv-headers, spirv-reflect, spirv-tools, volk, vulkan-headers, vulkan-hpp, vulkan-loader, vulkan-tools, vulkan-utility-libraries, and vulkan-validationlayers now reference the 1.4.335+0 SDK.
  • Checksum and Reference Updates: New checksums or Git tag/SDK version references have been added for each updated package to maintain integrity and accurate versioning within the build system.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various Vulkan-related packages to version 1.4.335+0. The changes are straightforward and consistent across all modified package files. I have one minor suggestion to improve code maintainability by ensuring version lists are sorted consistently.

Comment thread packages/v/vulkan-hpp/xmake.lua
Comment on lines +11 to 14
add_versions("v1.4.335", "9d55db6621613adf9ccea21dbc853fbd27ea2924")
add_versions("v1.4.309", "16da8bd29e5d0b921c92d406d194759c0df6a2b8")
add_versions("v1.2.180", "bfa6d4765212505c8241a44b97dc5a9ce3aa2969")
add_versions("v1.2.189", "58ff1da4c03f5f124eb835f41a9dd8fe3c2e8087")

@gemini-code-assist gemini-code-assist Bot Jan 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, it's best to keep the versions sorted. The other version blocks in this file and other package files are sorted. It seems the intended order here is descending, but v1.2.180 comes before v1.2.189. Please sort this block. You might also consider sorting the entire list of versions in this file to improve consistency.

    add_versions("v1.4.335", "9d55db6621613adf9ccea21dbc853fbd27ea2924")
    add_versions("v1.4.309", "16da8bd29e5d0b921c92d406d194759c0df6a2b8")
    add_versions("v1.2.189", "58ff1da4c03f5f124eb835f41a9dd8fe3c2e8087")
    add_versions("v1.2.180", "bfa6d4765212505c8241a44b97dc5a9ce3aa2969")

@SirLynix

SirLynix commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

FreeBSD seems to fail to install cmake:

2026-01-19T14:51:14.5407294Z �[0m�[2;38;5;1;1merror: �[0m@programdir/core/sandbox/modules/os.lua:100: cannot copy file bin, file not found!
2026-01-19T14:51:14.5407856Z stack traceback:
2026-01-19T14:51:14.5408086Z     [C]: in function 'error'
2026-01-19T14:51:14.5408358Z     [@programdir/core/base/os.lua:1125]:
2026-01-19T14:51:14.5408736Z     [@programdir/core/sandbox/modules/os.lua:100]: in function 'cp'
2026-01-19T14:51:14.5409211Z     [...make-repo/xmake-repo/packages/c/cmake/schemes/binary.lua:167]: in function 'install'
2026-01-19T14:51:14.5409826Z     [...er/work/xmake-repo/xmake-repo/packages/c/cmake/xmake.lua:49]: in function 'script'
2026-01-19T14:51:14.5410343Z     [...dir/modules/private/action/require/impl/utils/filter.lua:114]: in function 'call'
2026-01-19T14:51:14.5410807Z     [.../modules/private/action/require/impl/actions/install.lua:480]:
2026-01-19T14:51:14.5411137Z �[0m
2026-01-19T14:51:14.5411485Z �[0m�[38;5;3m  => �[0minstall cmake#1 >=3.17.2 �[2m(binary)�[0m .. �[38;5;1;1mfailed�[0m

@waruqi something with schemes?

@luadebug luadebug mentioned this pull request Jan 19, 2026
Closed
@waruqi

waruqi commented Jan 20, 2026

Copy link
Copy Markdown
Member

I will look at it.

@waruqi waruqi mentioned this pull request Jan 20, 2026
Merged
@waruqi

waruqi commented Jan 20, 2026

Copy link
Copy Markdown
Member

wait for this patch xmake-io/xmake#7245

@waruqi waruqi closed this Jan 20, 2026
@waruqi waruqi reopened this Jan 20, 2026
@waruqi waruqi merged commit 19ae80b into xmake-io:dev Jan 20, 2026
120 of 124 checks passed
@SirLynix SirLynix deleted the vulkan-sdk-1.4.335+0 branch January 20, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SirLynix @waruqi