Skip to content

Commit 5933140

Browse files
committed
fix: clear stale forms on server reconnect
When a managed service restarts, the server's form cache is empty but the TUI client may still hold pending forms in its local store. On server.connected, clear all locally-held forms and invalidate their sync keys so a subsequent re-sync cannot resurrect stale state. Fixes anomalyco#36585
1 parent 6ac14ee commit 5933140

2 files changed

Lines changed: 41 additions & 3 deletions

File tree

‎packages/client/src/solid/data.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -667,8 +667,10 @@ export function createData(config: CreateDataInput) {
667667
(sessionID) => store.session.form[sessionID]?.length,
668668
)
669669
if (formSessionIDs.length > 0) {
670-
setStore("session", "form", {})
671-
formSessionIDs.forEach((sessionID) => result.session.form.invalidate(sessionID))
670+
formSessionIDs.forEach((sessionID) => {
671+
setStore("session", "form", sessionID, undefined)
672+
result.session.form.invalidate(sessionID)
673+
})
672674
}
673675
return
674676
}

‎packages/client/test/solid-data.test.ts‎

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, test } from "bun:test"
22
import { getEventListeners } from "node:events"
33
import { createRoot } from "solid-js"
44
import { createData, type CreateDataInput } from "../src/solid"
5-
import { OpenCode, type ModelInfo, type OpenCodeEvent, type Project, type SessionInfo } from "../src/promise"
5+
import { OpenCode, type FormInfo, type ModelInfo, type OpenCodeEvent, type Project, type SessionInfo } from "../src/promise"
66

77
const session = (viewed: number): SessionInfo => ({
88
id: "ses_refresh",
@@ -1192,6 +1192,42 @@ test("projects background user shell metadata from durable shell data", () => {
11921192
}
11931193
})
11941194

1195+
test("clears stale forms on server reconnect", () => {
1196+
const form: FormInfo = {
1197+
id: "form_stale",
1198+
sessionID: "ses_refresh",
1199+
title: "Stale form",
1200+
fields: [{ key: "name", type: "string" }],
1201+
}
1202+
const setup = activityFixture(() => Response.json({ data: {} }))
1203+
try {
1204+
setup.emit({
1205+
id: "evt_form_created",
1206+
created: 1,
1207+
type: "form.created",
1208+
location: { directory: "/project" },
1209+
durable: { aggregateID: "ses_refresh", seq: 1, version: 1 },
1210+
data: { form },
1211+
})
1212+
expect(setup.data.session.form.list("ses_refresh")).toEqual([form])
1213+
1214+
setup.emit({ type: "server.connected", data: {} })
1215+
expect(setup.data.session.form.list("ses_refresh")).toBeUndefined()
1216+
1217+
setup.emit({
1218+
id: "evt_form_created_2",
1219+
created: 2,
1220+
type: "form.created",
1221+
location: { directory: "/project" },
1222+
durable: { aggregateID: "ses_refresh", seq: 2, version: 1 },
1223+
data: { form: { ...form, id: "form_new" } },
1224+
})
1225+
expect(setup.data.session.form.list("ses_refresh")).toEqual([{ ...form, id: "form_new" }])
1226+
} finally {
1227+
setup.dispose()
1228+
}
1229+
})
1230+
11951231
function modelInfo(name: string): ModelInfo {
11961232
return {
11971233
id: "chat",

0 commit comments

Comments
 (0)