Typescript changes#996
Merged
herschel666 merged 5 commits intomasterfrom Dec 6, 2019
Merged
Conversation
herschel666
added
the
📦 v12
jhiode
reviewed
Dec 3, 2019
herschel666
force-pushed
the
typescript-changes
branch
2 times, most recently
from
036d9c1 to
34a7ec8
Compare
Contributor
|
To be honest I'm not sure on how |
KnisterPeter
previously approved these changes
Dec 5, 2019
Contributor
|
I would say, lets try it out. If it does work as we hope/expect it to work, then we are a lot faster than without isolated modules. |
added 5 commits
December 5, 2019 18:10
herschel666
force-pushed
the
typescript-changes
branch
from
34a7ec8 to
737b824
Compare
KnisterPeter
approved these changes
Dec 6, 2019
jhiode
approved these changes
Dec 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hops-typescript'stsconfig.jsoncompilerOptionstarget- andmoduleResolution-properties aren't overwritten by the usertranspileOnlyandcompilerOptions.isolatedModulestotruefor the dev-serverI'm overall not happy with how the checks are done in the
diagnosis()-hook & don't lead to an error. Does anyone have a good idea to improve that?Also the
transpileOnly-feature doesn't lead tocompilerOptions.isolatedModulesbeing set totrueanymore since this PR, that apparently fixed this issue. Maybe we don't want to enable it either, but I'm not able to decide this now. 😑