Merged
Conversation
### What is this PR for? Trivial PR which just remove helium s3 url by default. This could solve zeppelin starting issue when users don't have internet access. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4479 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3678 from zjffdu/ZEPPELIN-4479 and squashes the following commits: 8ba4c0a [Jeff Zhang] [ZEPPELIN-4479]. Don't use helium url in s3 by default
### What is this PR for? This is an extension of ZEPPELIN-4377, I believe we should have an API validation for the same. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4679 ### How should this be tested? Calling directly API should fail, and if somehow this is by pass from UI, UI should also return proper error. ``` curl 'http://localhost:8080/api/interpreter/setting' -H 'Content-Type: application/json;charset=UTF-8' --data-binary '{"name":"test space","group":"angular","properties":{},"dependencies":[],"option":{"remote":true,"isExistingProcess":false,"setPermission":false,"session":false,"process":false,"perNote":"shared","perUser":"shared","owners":[]},"propertyValue":"","propertyKey":"","propertyType":"textarea"}' ``` ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <[email protected]> Closes #3684 from prabhjyotsingh/ZEPPELIN-4679 and squashes the following commits: 1fdddaf [Prabhjyot Singh] fix travis 485f8ff [Prabhjyot Singh] make pattern static constant to avoid its compilation everytime d787e75 [Prabhjyot Singh] add unit test 2c7a406 [Prabhjyot Singh] ZEPPELIN-4679: add API validation
…ission set ### What is this PR for? It is a simple PR just to initialize NoteAuth for the note without permission set (not in `notebook-authorization.json`). So that we won't get annoying warning log. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4682 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3688 from zjffdu/ZEPPELIN-4682 and squashes the following commits: 8a4e9b4 [Jeff Zhang] [ZEPPELIN-4682]. Should initialize NoteAuth for the note without permission set
### What is this PR for? This is a minor PR which just shade thrift in zeppelin-interpreter-shaded as well. Besides that I also remove the TException, this is thrift exception, we should expose it to users. Otherwise we need to use the shaded version of TException which is inconvenient for users. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4681 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jeff Zhang <[email protected]> Closes #3685 from zjffdu/ZEPPELIN-4681 and squashes the following commits: 4ee1c47 [Jeff Zhang] [ZEPPELIN-4681]. Shade thrift in zeppelin-interpreter-shaded
…disable JobManager ### What is this PR for? For zeppelin will load all notes in 2 places. One is QuartzSchedulerService.java where it would read all notes and refresh their cron job. Another is JobManagerService. In order to solve the memory issue, I introduce the `unLoad` method in `Note` to release memory in `QuartzSchedulerService` after refreshing cron job. Another approach is to disable JobManager (Job tab in zeppelin UI), The Job tab is not so useful IMHO. We should redesign that only to show the cron enabled jobs. But this redesign should be done later in another PR. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4680 ### How should this be tested? * Manually tested ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3686 from zjffdu/ZEPPELIN-4680 and squashes the following commits: a732f99 [Jeff Zhang] [ZEPPELIN-4680]. Add method to release note memory and add option to disable JobManager
xiejiajun
added a commit
that referenced
this pull request
Nov 15, 2020
…Spark Interpreter Scala REPL and fix the CI failure due to low Scala version ### What is this PR for? - fix the [CI failure](https://travis-ci.org/github/apache/zeppelin/builds/709913046) due to [PR-3852](apache#3852) ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * [ZEPPELIN-4962](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4962) ### How should this be tested? * CI test ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? Yes Author: xiejiajun <[email protected]> Author: xie-jia-jun <[email protected]> Author: JakeXie <[email protected]> Closes apache#3860 from xiejiajun/ZEPPELIN-4962 and squashes the following commits: 9128c9b [JakeXie] spark.repl.target docs update ad4c0e3 [xiejiajun] Clear irrelevant code a12d3a9 [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL and fix the CI failure due to low Scala version ab2b191 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master 5569788 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master 0a9af6c [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master be36b37 [xiejiajun] 合并Apache Master分支冲突解决 1335d55 [xiejiajun] Merge remote-tracking branch 'origin/master' fc59f57 [JakeXie] Merge pull request #4 from apache/master 9cc70fe [xiejiajun] Merge remote-tracking branch 'origin/master' 6ef9b23 [xie-jia-jun] Merge pull request #3 from apache/master 45af87a [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly f149c3b [xie-jia-jun] Merge pull request #1 from apache/master 5d4b645 [xie-jia-jun] Support OSSConfigStorage of Aliyun dbb6639 [xie-jia-jun] Add Aliyun OSS SDK bb47849 [xie-jia-jun] Support S3ConfigStorage of AWS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: